geekinney/tp
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

refactor: address code review feedback - fix error message and extract helper function

Browse Source 
Co-authored-by: Kinneyzhang <38454496+Kinneyzhang@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot] 2025-12-20 08:45:52 +00:00
parent 7dad0f1789
commit 33f3ec3d7a
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
tp.el
View File

@ -251,7 +251,7 @@ NEWVAL is the new value, OLDVAL is the old value."
(condition-case err (condition-case err
(funcall callback newval oldval layer-name) (funcall callback newval oldval layer-name)
(error (message "tp: watcher error for %s watching %s: %s" (error (message "tp: watcher error for %s watching %s: %s"
layer-name symbol err)))))))) layer-name watch-sym err))))))))
(defun tp--update-layer-computed (layer-name override-alist) (defun tp--update-layer-computed (layer-name override-alist)
"Update computed properties for LAYER-NAME with OVERRIDE-ALIST. "Update computed properties for LAYER-NAME with OVERRIDE-ALIST.
@ -301,6 +301,16 @@ COMPUTED is a plist of (PROP-KEY COMPUTE-FN) pairs."
"Unregister all computed properties for LAYER-NAME." "Unregister all computed properties for LAYER-NAME."
(setq tp-layer-computed (assq-delete-all layer-name tp-layer-computed))) (setq tp-layer-computed (assq-delete-all layer-name tp-layer-computed)))
(defun tp--apply-initial-computed (resolved-props compute)
"Apply initial computed values to RESOLVED-PROPS using COMPUTE definitions.
COMPUTE is a plist of (PROP-KEY COMPUTE-FN) pairs.
Returns the modified RESOLVED-PROPS."
(cl-loop for (prop-key compute-fn) on compute by #'cddr
do (let ((val (tp--resolve-reactive-symbols (funcall compute-fn) nil)))
(when val
(setq resolved-props (plist-put resolved-props prop-key val)))))
resolved-props)
(defun tp--update-layer-regions (layer-name) (defun tp--update-layer-regions (layer-name)
"Update all text regions that have LAYER-NAME applied. "Update all text regions that have LAYER-NAME applied.
Re-applies the layer properties using tp-search-map and tp-add." Re-applies the layer properties using tp-search-map and tp-add."
@ -1946,12 +1956,7 @@ The layer is stored in `tp-layer-alist'."
(let ((resolved-props (tp--resolve-reactive-symbols ',properties))) (let ((resolved-props (tp--resolve-reactive-symbols ',properties)))
;; Apply initial computed values ;; Apply initial computed values
,@(when compute ,@(when compute
`((cl-loop for (prop-key compute-fn) on ',compute by #'cddr `((setq resolved-props (tp--apply-initial-computed resolved-props ',compute))))
do (let ((val (tp--resolve-reactive-symbols
(funcall compute-fn) nil)))
(when val
(setq resolved-props
(plist-put resolved-props prop-key val)))))))
(tp--set-layer-props ',name resolved-props)) (tp--set-layer-props ',name resolved-props))
(assoc ',name tp-layer-alist)) (assoc ',name tp-layer-alist))
;; No reactive symbols - use static properties ;; No reactive symbols - use static properties
@ -2121,12 +2126,7 @@ and the group itself is stored in `tp-layer-groups'."
`((tp--register-layer-computed ',layer-name ',compute))) `((tp--register-layer-computed ',layer-name ',compute)))
(let ((resolved-props (tp--resolve-reactive-symbols ',props))) (let ((resolved-props (tp--resolve-reactive-symbols ',props)))
,@(when compute ,@(when compute
`((cl-loop for (prop-key compute-fn) on ',compute by #'cddr `((setq resolved-props (tp--apply-initial-computed resolved-props ',compute))))
do (let ((val (tp--resolve-reactive-symbols
(funcall compute-fn) nil)))
(when val
(setq resolved-props
(plist-put resolved-props prop-key val)))))))
(tp--set-layer-props ',layer-name resolved-props))) (tp--set-layer-props ',layer-name resolved-props)))
layer-defs) layer-defs)
;; No reactive symbols - use static properties ;; No reactive symbols - use static properties