geekinney/tp
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: Address code review feedback

Browse Source 
- Remove duplicate tp--resolve-reactive-symbols call (use resolved-props instead)
- Simplify tp--generate-anonymous-layer-name to use counter only

Co-authored-by: Kinneyzhang <38454496+Kinneyzhang@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot] 2025-12-20 07:53:14 +00:00
parent 56733e7473
commit 0dba4d2a07
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tp.el
View File

@ -66,11 +66,9 @@ only (face (:foreground $color)) is stored, not the help-echo.")
(defun tp--generate-anonymous-layer-name () (defun tp--generate-anonymous-layer-name ()
"Generate a unique symbol for anonymous layers. "Generate a unique symbol for anonymous layers.
Uses a combination of timestamp and counter to ensure uniqueness." Uses a counter to ensure uniqueness within an Emacs session."
(setq tp--anonymous-layer-counter (1+ tp--anonymous-layer-counter)) (setq tp--anonymous-layer-counter (1+ tp--anonymous-layer-counter))
(intern (format "tp-anon-%s-%d" (intern (format "tp-anon-%d" tp--anonymous-layer-counter)))
(format-time-string "%s%N")
tp--anonymous-layer-counter)))
;;; Reactive Text Properties Functions ;;; Reactive Text Properties Functions
@ -1998,8 +1996,8 @@ For group names, includes `tp-layers' property with the full layer stack."
(let* ((layer-name (or existing-tp-name (tp--generate-anonymous-layer-name))) (let* ((layer-name (or existing-tp-name (tp--generate-anonymous-layer-name)))
;; Resolve reactive symbols to get current values ;; Resolve reactive symbols to get current values
(resolved-props (tp--resolve-reactive-symbols props))) (resolved-props (tp--resolve-reactive-symbols props)))
;; Register this anonymous layer in tp-layer-alist with original template ;; Register this anonymous layer in tp-layer-alist with resolved props
(tp--set-layer-props layer-name (tp--resolve-reactive-symbols props)) (tp--set-layer-props layer-name resolved-props)
;; Register reactive dependencies with the original template props ;; Register reactive dependencies with the original template props
(tp--register-reactive-deps layer-name reactive-syms props) (tp--register-reactive-deps layer-name reactive-syms props)
;; Return resolved props with tp-name ;; Return resolved props with tp-name