From 9b89115b5dc0bddd9ed107305899167ea373c018 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 10 Feb 2026 12:19:22 +0000 Subject: [PATCH] fix: address code review feedback - improve docstrings and use defalias consistently Co-authored-by: Kinneyzhang <38454496+Kinneyzhang@users.noreply.github.com> --- _codeql_detected_source_root | 1 + ekp-utils.el | 3 +-- ekp.el | 6 ++++-- 3 files changed, 6 insertions(+), 4 deletions(-) create mode 120000 _codeql_detected_source_root diff --git a/_codeql_detected_source_root b/_codeql_detected_source_root new file mode 120000 index 0000000..fe661d3 --- /dev/null +++ b/_codeql_detected_source_root @@ -0,0 +1 @@ +./ekp_c \ No newline at end of file diff --git a/ekp-utils.el b/ekp-utils.el index 8e73280..49bb77c 100644 --- a/ekp-utils.el +++ b/ekp-utils.el @@ -260,8 +260,7 @@ Whitespace runs are preserved as separate boxes; CJK punctuation attaches to pre ;;; Rust Module Support (currently unused — ekp_rust/ directory does not exist) -(defun ekp-rust-module-reload (module) - (ekp--module-reload module)) +(defalias 'ekp-rust-module-reload #'ekp--module-reload) (defun ekp-module-dir () (when-let ((root-dir (ekp-root-dir))) diff --git a/ekp.el b/ekp.el index 97113a3..60b067d 100644 --- a/ekp.el +++ b/ekp.el @@ -541,10 +541,12 @@ Uses binary search for O(log n) lookup." (= (aref vec lo) n)))) (defalias 'ekp--hyphenate-p #'ekp--sorted-vector-member-p - "Return non-nil if position N ends with hyphenation.") + "Return non-nil if position N in HYPHEN-POSITIONS ends with hyphenation. +HYPHEN-POSITIONS is a sorted vector of indices where hyphenation can occur.") (defalias 'ekp--flagged-p #'ekp--sorted-vector-member-p - "Return non-nil if position N is a flagged (forced) break.") + "Return non-nil if position N in FLAGGED-POSITIONS is a flagged (forced) break. +FLAGGED-POSITIONS is a sorted vector of indices where forced breaks occur.") ;;;; Dynamic Programming Line Breaking